From 7216c72509cc584eda520787a96e53cbd3377b8f Mon Sep 17 00:00:00 2001 From: James G Sack Date: Sat, 29 Dec 2007 03:00:46 +0000 Subject: [PATCH] fix confusing dup function name (fn -> fn3) svn: r9618 --- ChangeLog | 5 +++++ src/gen/utils/test/callback_test.py | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e03294c60..97c7e507a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2007-12-28 Jim Sack + * src/gen/utils/test/callback_test.py: rename dup name (fn -> fn3) + The dup name was harmless but confusing, and a potential future + problem. Thanks to Raphael Ackermann for pointing this out. + 2007-12-28 Benny Malengier * src/ViewManager.py: remove unused functions, add alt actions left/right * src/GrampsDb: deleted with _GrampsDbWriteXML.py, diff --git a/src/gen/utils/test/callback_test.py b/src/gen/utils/test/callback_test.py index bcdeded53..c0f227374 100644 --- a/src/gen/utils/test/callback_test.py +++ b/src/gen/utils/test/callback_test.py @@ -227,9 +227,9 @@ class TestGrampsDBCallback(unittest.TestCase): # This should fail because the type of arg1 is wrong res=[] - def fn(s,r=res): + def fn3(s,r=res): res.append(s) - t._warn = fn + t._warn = fn3 t.connect('test-lots',fn2), t.emit('test-lots',('a','a',[1,2],t,1.2)) assert res[0][0:6] == "Signal", "Type error not detected"