beckermj/vaguerent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add tests for basis

Browse Source
This commit is contained in:
sophia 2022-02-24 17:53:55 -06:00 committed by Paul Hinze
parent 7f0adfce78
commit 0731b5486a
No known key found for this signature in database
GPG Key ID: B69DEDF2D55501C0
3 changed files with 183 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

150
internal/core/basis_test.go Normal file
View File

@ -0,0 +1,150 @@
package core
import (
"testing"
"github.com/hashicorp/vagrant-plugin-sdk/component"
coremocks "github.com/hashicorp/vagrant-plugin-sdk/core/mocks"
"github.com/hashicorp/vagrant/internal/plugin"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
)
func TestBasisPlugins(t *testing.T) {
myguest := plugin.TestPlugin(t,
plugin.WithPluginName("myguest"),
plugin.WithPluginMinimalComponents(component.GuestType, &coremocks.Guest{}),
)
myguesttwo := plugin.TestPlugin(t,
plugin.WithPluginName("myguesttwo"),
plugin.WithPluginMinimalComponents(component.GuestType, &coremocks.Guest{}),
)
myhost := plugin.TestPlugin(t,
plugin.WithPluginName("myhost"),
plugin.WithPluginMinimalComponents(component.HostType, &coremocks.Host{}),
)
mysf := plugin.TestPlugin(t,
plugin.WithPluginName("mysf"),
plugin.WithPluginMinimalComponents(component.SyncedFolderType, &coremocks.SyncedFolder{}),
)
type test struct {
plugins []*plugin.Plugin
pluginType string
expectedPlugins int
}
tests := []test{
{plugins: []*plugin.Plugin{myguest, myhost, mysf}, pluginType: "guest", expectedPlugins: 1},
{plugins: []*plugin.Plugin{myguest, myguesttwo, myhost, mysf}, pluginType: "guest", expectedPlugins: 2},
{plugins: []*plugin.Plugin{myguest, myguesttwo, myhost, mysf}, pluginType: "host", expectedPlugins: 1},
{plugins: []*plugin.Plugin{}, pluginType: "host"},
}
for _, tc := range tests {
pluginManager := plugin.TestManager(t, tc.plugins...)
b := TestBasis(t, WithPluginManager(pluginManager))
plgs, err := b.Plugins(tc.pluginType)
require.NoError(t, err)
require.Len(t, plgs, tc.expectedPlugins)
}
}
// TODO: (sophia) the ConfigVagrant structure should be at a higher level than Machineconfigs
// func TestBasisConfigedHost(t *testing.T) {
// type test struct {
// config *vagrant_plugin_sdk.Vagrantfile_Vagrantfile
// errors bool
// }
// tests := []test{
// {config: &vagrant_plugin_sdk.Vagrantfile_Vagrantfile{}, errors: false},
// {config: &vagrant_plugin_sdk.Vagrantfile_Vagrantfile{}, errors: true},
// }
// hostMock := seededHostMock("myhost")
// pluginManager := plugin.TestManager(t,
// plugin.TestPlugin(t,
// plugin.WithPluginName("myhost"),
// plugin.WithPluginMinimalComponents(component.HostType, hostMock)),
// )
// for _, tc := range tests {
// b := TestBasis(t,
// WithPluginManager(pluginManager),
// WithTestBasisConfig(tc.config),
// )
// host, err := b.Host()
// if tc.errors {
// require.Error(t, err)
// require.Nil(t, host)
// } else {
// require.NoError(t, err)
// require.NotNil(t, host)
// }
// }
// }
func TestBasisNoConfigHost(t *testing.T) {
hostMock := seededHostMock("myhost")
hostMock.On("Detect", mock.AnythingOfType("*core.StateBag")).Return(true, nil)
detectPluginInstance := plugin.TestPluginInstance(t,
plugin.WithPluginInstanceName("myhost"),
plugin.WithPluginInstanceType(component.HostType),
plugin.WithPluginInstanceComponent(hostMock))
detectingPlugin := plugin.TestPlugin(t,
plugin.WithPluginName("myhost"),
plugin.WithPluginInstance(detectPluginInstance))
notHostMock := seededHostMock("mynondetectinghost")
notHostMock.On("Detect", mock.AnythingOfType("*core.StateBag")).Return(false, nil)
nonDetectingPlugin := plugin.TestPlugin(t,
plugin.WithPluginName("mynondetectinghost"),
plugin.WithPluginMinimalComponents(component.HostType, notHostMock))
hostChildMock := seededHostMock("myhost-child")
hostChildMock.On("Detect", mock.AnythingOfType("*core.StateBag")).Return(true, nil)
detectChildPluginInstance := plugin.TestPluginInstance(t,
plugin.WithPluginInstanceName("myhost-child"),
plugin.WithPluginInstanceType(component.HostType),
plugin.WithPluginInstanceComponent(hostChildMock),
plugin.WithPluginInstanceParent(detectPluginInstance))
detectingChildPlugin := plugin.TestPlugin(t,
plugin.WithPluginName("myhost-child"),
plugin.WithPluginInstance(detectChildPluginInstance),
)
type test struct {
plugins []*plugin.Plugin
errors bool
expectedPluginName string
}
tests := []test{
{plugins: []*plugin.Plugin{detectingPlugin}, errors: false, expectedPluginName: "myhost"},
{plugins: []*plugin.Plugin{detectingChildPlugin}, errors: false, expectedPluginName: "myhost-child"},
{plugins: []*plugin.Plugin{detectingChildPlugin, detectingPlugin}, errors: false, expectedPluginName: "myhost-child"},
{plugins: []*plugin.Plugin{detectingPlugin, nonDetectingPlugin}, errors: false, expectedPluginName: "myhost"},
{plugins: []*plugin.Plugin{nonDetectingPlugin}, errors: true},
{plugins: []*plugin.Plugin{}, errors: true},
}
for _, tc := range tests {
pluginManager := plugin.TestManager(t, tc.plugins...)
b := TestBasis(t,
WithPluginManager(pluginManager),
)
host, err := b.Host()
if tc.errors {
require.Error(t, err)
require.Nil(t, host)
} else {
n, _ := host.PluginName()
if n != tc.expectedPluginName {
t.Error("Found unexpected plugin, ", n)
}
require.NoError(t, err)
require.NotNil(t, host)
}
}
}

17
internal/core/machine_test.go
View File

@ -5,8 +5,6 @@ import (
"github.com/hashicorp/vagrant-plugin-sdk/component"
"github.com/hashicorp/vagrant-plugin-sdk/core"
sdkcore "github.com/hashicorp/vagrant-plugin-sdk/core"
coremocks "github.com/hashicorp/vagrant-plugin-sdk/core/mocks"
"github.com/hashicorp/vagrant-plugin-sdk/proto/vagrant_plugin_sdk"
"github.com/hashicorp/vagrant/internal/plugin"
"github.com/hashicorp/vagrant/internal/server/proto/vagrant_server"
@ -14,21 +12,6 @@ import (
"github.com/stretchr/testify/require"
)
func seededGuestMock(name string) *coremocks.Guest {
guestMock := &coremocks.Guest{}
guestMock.On("Seeds").Return(sdkcore.NewSeeds(), nil)
guestMock.On("Seed", mock.AnythingOfType("")).Return(nil)
guestMock.On("PluginName").Return(name, nil)
return guestMock
}
func seededSyncedFolderMock(name string) *coremocks.SyncedFolder {
guestMock := &coremocks.SyncedFolder{}
guestMock.On("Seeds").Return(sdkcore.NewSeeds(), nil)
guestMock.On("Seed", mock.AnythingOfType("")).Return(nil)
return guestMock
}
func TestMachineSetValidId(t *testing.T) {
tm, _ := TestMinimalMachine(t)

33
internal/core/testing_basis.go
View File

@ -5,13 +5,39 @@ import (
"io/ioutil"
"os"
sdkcore "github.com/hashicorp/vagrant-plugin-sdk/core"
coremocks "github.com/hashicorp/vagrant-plugin-sdk/core/mocks"
"github.com/hashicorp/vagrant-plugin-sdk/datadir"
"github.com/hashicorp/vagrant-plugin-sdk/proto/vagrant_plugin_sdk"
"github.com/hashicorp/vagrant/internal/server/singleprocess"
"github.com/mitchellh/go-testing-interface"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
)
func seededHostMock(name string) *coremocks.Host {
guestMock := &coremocks.Host{}
guestMock.On("Seeds").Return(sdkcore.NewSeeds(), nil)
guestMock.On("Seed", mock.AnythingOfType("")).Return(nil)
guestMock.On("PluginName").Return(name, nil)
return guestMock
}
func seededGuestMock(name string) *coremocks.Guest {
guestMock := &coremocks.Guest{}
guestMock.On("Seeds").Return(sdkcore.NewSeeds(), nil)
guestMock.On("Seed", mock.AnythingOfType("")).Return(nil)
guestMock.On("PluginName").Return(name, nil)
return guestMock
}
func seededSyncedFolderMock(name string) *coremocks.SyncedFolder {
guestMock := &coremocks.SyncedFolder{}
guestMock.On("Seeds").Return(sdkcore.NewSeeds(), nil)
guestMock.On("Seed", mock.AnythingOfType("")).Return(nil)
return guestMock
}
func TestBasis(t testing.T, opts ...BasisOption) (b *Basis) {
td, err := ioutil.TempDir("", "core")
require.NoError(t, err)
@ -29,3 +55,10 @@ func TestBasis(t testing.T, opts ...BasisOption) (b *Basis) {
b, _ = NewBasis(context.Background(), append(defaultOpts, opts...)...)
return
}
func WithTestBasisConfig(config *vagrant_plugin_sdk.Vagrantfile_Vagrantfile) BasisOption {
return func(m *Basis) (err error) {
m.basis.Configuration = config
return
}
}