From 7c8e204b8c2902641ccac17c85826ead7e8bca96 Mon Sep 17 00:00:00 2001 From: sophia Date: Mon, 8 Mar 2021 16:49:52 -0600 Subject: [PATCH] Use test doubles instead of 'true' --- test/unit/plugins/providers/docker/provider_test.rb | 2 +- .../plugins/provisioners/puppet/provisioner/puppet_test.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/unit/plugins/providers/docker/provider_test.rb b/test/unit/plugins/providers/docker/provider_test.rb index 3cb6e03cb..d2dec86a7 100644 --- a/test/unit/plugins/providers/docker/provider_test.rb +++ b/test/unit/plugins/providers/docker/provider_test.rb @@ -78,7 +78,7 @@ describe VagrantPlugins::DockerProvider::Provider do it "returns the host machine object" do allow(machine.provider_config).to receive(:vagrant_vagrantfile).and_return("/path/to/Vagrantfile") allow(machine.provider_config).to receive(:vagrant_machine).and_return(:default) - allow(machine).to receive(:env).and_return(true) + allow(machine).to receive(:env).and_return(double("env")) allow(machine.env).to receive(:root_path).and_return("/.vagrant.d") allow(machine.env).to receive(:home_path).and_return("/path/to") allow(machine.env).to receive(:ui_class).and_return(true) diff --git a/test/unit/plugins/provisioners/puppet/provisioner/puppet_test.rb b/test/unit/plugins/provisioners/puppet/provisioner/puppet_test.rb index c4ee727cc..2bef6892e 100644 --- a/test/unit/plugins/provisioners/puppet/provisioner/puppet_test.rb +++ b/test/unit/plugins/provisioners/puppet/provisioner/puppet_test.rb @@ -81,7 +81,7 @@ describe VagrantPlugins::Puppet::Provisioner::Puppet do let(:environment_paths) { ["/etc/puppet/environment"] } it "builds structured facts if set" do - allow(machine).to receive(:guest).and_return(true) + allow(machine).to receive(:guest).and_return(double("guest")) allow(machine.guest).to receive(:capability?).and_return(false) allow(config).to receive(:environment_path).and_return(environment_paths) allow(config).to receive(:environment).and_return("production") @@ -105,7 +105,7 @@ describe VagrantPlugins::Puppet::Provisioner::Puppet do end it "does not build structured facts if not set" do - allow(machine).to receive(:guest).and_return(true) + allow(machine).to receive(:guest).and_return(double("guest")) allow(machine.guest).to receive(:capability?).and_return(false) allow(config).to receive(:environment_path).and_return(environment_paths) allow(config).to receive(:environment).and_return("production")