Jeff Bonhag
5abde797e4
Forward #storage_controller to driver
2020-07-09 15:07:47 -04:00
Jeff Bonhag
61f59de69b
Extract StorageController object
2020-07-09 15:07:47 -04:00
Jeff Bonhag
2e879aa06f
Scan storage controllers for DVD cleanup
2020-07-09 15:07:47 -04:00
Jeff Bonhag
8739c04aa9
Mock out storage controllers
2020-07-09 15:07:47 -04:00
Jeff Bonhag
8407d79100
Refactor disk configuration to use dynamic names
...
This commit adds a new VirtualBox provider helper method to return a
list of storage controllers so Vagrant can find a storage controller
with the desired characteristics (type IDE or SATA).
This still needs to get wired up to the disk cleanup method.
2020-07-09 15:07:46 -04:00
Jeff Bonhag
8985369eab
Raise an error if disk files are re-used in config
2020-07-09 15:07:46 -04:00
Jeff Bonhag
c52eb1b44c
Feature: ISO attachment for VirtualBox
...
This builds on the existing disk functionality, and adds some special
IDE controller-related flavor.
Considerations for IDE controllers:
- Primary/secondary attachments, so that each port can have two devices
attached
- Adding the ability to address a specific controller name for disk
attachment
This also prevents a user from attaching multiple instances of the same
ISO file, because VirtualBox will assign each of these the same UUID
which makes disconnection difficult. However, if multiple copies of the
ISO are attached to different devices, removing the DVD config will
cause the duplicate devices to be removed.
We may want to consider additional work to make the storage controllers
truly generic.
2020-07-09 15:07:27 -04:00
Sophia Castellarin
02ef62dcff
Merge pull request #11694 from soapy1/host-cap-build-iso
...
Build iso for Darwin host
2020-07-07 10:29:52 -05:00
Brian Cain
88c2bc2be1
Merge pull request #11541 from briancain/feature/hyperv-disk-mgmt
...
[Feature] Hyper-V Virtual Hard Disk Management
2020-07-06 15:24:29 -07:00
Sophia Castellarin
71620f6803
Merge pull request #11631 from soapy1/error-nfs-on-win
...
Error nfs on win
2020-07-02 10:19:06 -05:00
sophia
afae8c5640
Make tests check for output directory creation
2020-07-02 09:53:40 -05:00
Brian Cain
0139d8f020
Simplify other select to detect instead
2020-06-30 14:23:34 -07:00
Brian Cain
39b5bb4beb
Simplify selecting disk from all_disks hash
2020-06-30 14:23:34 -07:00
Brian Cain
05d3045f3a
Add RDoc for list_hdds
2020-06-30 14:23:34 -07:00
Brian Cain
9c1338b335
Fix typo in logger message
2020-06-30 14:23:34 -07:00
Brian Cain
af20d4a426
Remove old comment
2020-06-30 14:23:34 -07:00
Brian Cain
d35feb62a3
Simplify key check for provider option config
2020-06-30 14:23:34 -07:00
Brian Cain
b36db04b3d
Validate and get default disk extensions for provider
...
This commit updates the hyperv and virtualbox provider caps to validate
and also return the default disk extension.
2020-06-30 14:23:34 -07:00
Brian Cain
13c91d68a6
Only grab provider_config if provider key exists and config isn't empty
2020-06-30 14:23:34 -07:00
Brian Cain
1579ac9c3a
Update method docs to include expected opts keys
2020-06-30 14:23:34 -07:00
Brian Cain
69dff3a4c8
Use key? helper
2020-06-30 14:23:34 -07:00
Brian Cain
ae0fb6f857
Update check for provider_config availability
2020-06-30 14:23:34 -07:00
Brian Cain
a279f89d29
update how value is checked for execute in hyper-v driver
2020-06-30 14:23:34 -07:00
Brian Cain
71f6b97153
Delete old comments
2020-06-30 14:23:34 -07:00
Brian Cain
c063ca6100
Replace invalid disk name characters with underscore
2020-06-30 14:23:34 -07:00
Brian Cain
96d19264b6
Automatically remove invalid file characters for disk name
...
This commit copies what Vagrant does to filter out guest names with
invalid characters, and applies the same regex to disk names.
2020-06-30 14:23:34 -07:00
Brian Cain
4130cfe497
Properly check for disk paths when cleaning up disks in hyper-v
2020-06-30 14:23:34 -07:00
Brian Cain
66fe2e2854
Ensure size param is set for a disk
2020-06-30 14:23:34 -07:00
Brian Cain
18b9ccd0a5
Remove unused local var
2020-06-30 14:23:34 -07:00
Brian Cain
38445935dd
Ensure params are UInt32 rather than string
2020-06-30 14:23:34 -07:00
Brian Cain
f8dfcadb70
Only convert BlockSizeBytes option for Hyper-V disk provider_config
2020-06-30 14:23:34 -07:00
Brian Cain
56645b7bc5
Finish up configure_disk_test unit tests
2020-06-30 14:23:34 -07:00
Brian Cain
43eaceef13
Update disk meta keys to be consistent with Hyper-V keys
2020-06-30 14:23:34 -07:00
Brian Cain
754928a206
Ensure provider_config is a hash before calling .empty?
2020-06-30 14:23:34 -07:00
Brian Cain
d07e6c5c6a
Rearrange hyperv disk driver methods
2020-06-30 14:23:34 -07:00
Brian Cain
cf063c6e38
Update validation to look for if provider_config is empty not nil
2020-06-30 14:22:41 -07:00
Brian Cain
be939fcb59
Remove extra comments
2020-06-30 14:22:41 -07:00
Brian Cain
192caab02d
Fix provider_config merging for disk config
2020-06-30 14:22:41 -07:00
Brian Cain
1d8db27340
Fixup handling parameters for hyper-v powershell disk scripts
2020-06-30 14:22:41 -07:00
Brian Cain
bb4541a2a5
Remove stale comment
2020-06-30 14:22:41 -07:00
Brian Cain
0c19e6da26
Fix typo
2020-06-30 14:22:41 -07:00
Brian Cain
d30482a502
Explicitly pass along optional params
2020-06-30 14:22:41 -07:00
Brian Cain
bbe9a637e7
Convert size options into byte form
2020-06-30 14:22:41 -07:00
Brian Cain
9e8343fc93
Automatically add all passed in parameters to hyper-v command
2020-06-30 14:22:41 -07:00
Brian Cain
f798afa0c0
Attempt to pass along parameters
2020-06-30 14:22:41 -07:00
Brian Cain
cafb6ec239
Remove extra provider_config option
2020-06-30 14:22:41 -07:00
Brian Cain
2de5ef0bf2
Fix typo in new_vhd powershell script name
2020-06-30 14:22:41 -07:00
Brian Cain
cc2dc9a1e1
Use disk file from config if defined
2020-06-30 14:22:41 -07:00
Brian Cain
1dbda081d2
Add notes for creating disk options
2020-06-30 14:22:41 -07:00
Brian Cain
ed0fdbf868
Add note about attaching disks
2020-06-30 14:22:41 -07:00
