Brian Cain
d215d9d785
Only log warning when cleaning up disks
...
If a disk exists but isn't attached to a guest, don't attempt to remove
disk from guest.
2020-02-10 12:58:11 -08:00
Brian Cain
2e53c21fea
Return empty hash instead of null from configure_disks
2020-02-10 12:58:11 -08:00
Brian Cain
df742603cb
Add code comment about when SATA controller has no more open ports
2020-02-10 12:58:11 -08:00
Brian Cain
3d4d0be58f
Attach disk to next available port to avoid port fragmentation
...
This commit ensures that vagrant attaches a new disk to the _next
available_ port, rather than the last one "used". This can occur if a
disk has been removed in a previous run, leaving a port open
2020-02-10 12:58:11 -08:00
Brian Cain
c0fb8af1a3
Fix NUMBER typo
2020-02-10 12:58:11 -08:00
Brian Cain
2db81b049b
Only look at SATA Controller disk images
2020-02-10 12:58:11 -08:00
Brian Cain
f6a5a3ae41
Simplify determining next port to use
2020-02-10 12:58:11 -08:00
Brian Cain
9a5ce8381b
Add comment field for new disks
2020-02-10 12:58:11 -08:00
Brian Cain
98a81aac6b
Move show_vm_info call
2020-02-10 12:58:11 -08:00
Brian Cain
1b5f8760d0
Simplify get_port_device and add note about duplicated method in class
2020-02-10 12:58:11 -08:00
Brian Cain
8407fb28cb
Add more code comments for configuring disk class
2020-02-10 12:58:11 -08:00
Brian Cain
6376962209
Simplify obtaining port and device number info
2020-02-10 12:58:11 -08:00
Brian Cain
c049dd9211
Rename method to match functionality
...
This method now only returns the next available port, as virtualbox
guests can only have 1 device controller.
2020-02-10 12:58:11 -08:00
Brian Cain
6676fe6f7f
Remove stale TODOs
2020-02-10 12:58:11 -08:00
Brian Cain
524d98fe5c
Add comment about MAX_DISK_SIZE const
2020-02-10 12:58:11 -08:00
Brian Cain
cb3cc42dce
Determine primary disk through vm_info rather than list_hdds
2020-02-10 12:58:11 -08:00
Brian Cain
17b75db35b
Move disk driver methods into virtualbox version 5
2020-02-10 12:58:11 -08:00
Brian Cain
fddcd71eaf
Default to vdi since virtualbox default is vdi
2020-02-10 12:58:11 -08:00
Brian Cain
2176216bf8
Add error for when disks defined are greater than the max limit
2020-02-10 12:58:11 -08:00
Brian Cain
1e2570a599
Add methods for controller attaching
2020-02-10 12:58:11 -08:00
Brian Cain
a3b07a884a
Add way to configure disk extension
2020-02-10 12:58:11 -08:00
Brian Cain
4a4a48b69c
More descriptive name for disk data
2020-02-10 12:58:11 -08:00
Brian Cain
91e9de79a9
Add warning for currently unsupported disk types
2020-02-10 12:58:11 -08:00
Brian Cain
b388b34846
Update todos and method docs
2020-02-10 12:58:11 -08:00
Brian Cain
7215764130
Remove medium vars from base driver
2020-02-10 12:58:11 -08:00
Brian Cain
e31b013df8
Ensure vmdk disks that are resized stay in original format
2020-02-10 12:58:11 -08:00
Brian Cain
16c38ed9f4
Fix params for attach_disk driver call
2020-02-10 12:58:11 -08:00
Brian Cain
c679b3f470
Remove TODO
2020-02-10 12:58:11 -08:00
Brian Cain
424450cf16
Change info level from removing disks to WARN
2020-02-10 12:58:11 -08:00
Brian Cain
98ab1798a2
Only cleanup disks if defined from previous run
2020-02-10 12:58:11 -08:00
Brian Cain
d810f32ec5
Move message into info rather than detail for visibility
2020-02-10 12:58:11 -08:00
Brian Cain
9712c599fe
Update method docs for cleanup_disks cap
2020-02-10 12:58:11 -08:00
Brian Cain
71c3e36635
Raise exception if port and device cannot be determined
2020-02-10 12:58:11 -08:00
Brian Cain
4d4844fdef
Simplify params for virtualbox driver attach_disk
2020-02-10 12:58:11 -08:00
Brian Cain
6ba621ac92
Add ability to cleanup and close mediums for a guest
2020-02-10 12:58:11 -08:00
Brian Cain
ad798c2c12
Pass in disk meta file for cleanup_disks
2020-02-10 12:58:11 -08:00
Brian Cain
5d723b4e23
Include cleanup_disk action for virtualbox plugin
2020-02-10 12:58:11 -08:00
Brian Cain
e4a57a8e1d
Add virtualbox cleanup_disks action
2020-02-10 12:58:11 -08:00
Brian Cain
c2e6b5ae78
Ensure disks that go unchanged still get written into disk metadata file
2020-02-10 12:58:11 -08:00
Brian Cain
ffe8fcef9b
Make name required for defining non-primary disks
2020-02-10 12:58:11 -08:00
Brian Cain
ec350861cd
Write down metadata for disk configs after configuring disks
2020-02-10 12:58:11 -08:00
Brian Cain
ff77e6279b
Remove todo comment
2020-02-10 12:58:11 -08:00
Brian Cain
831b39f9e0
Use correct variable for disk name
2020-02-10 12:58:11 -08:00
Brian Cain
26d922ad0e
Add todo for fixing default disk names
2020-02-10 12:58:11 -08:00
Brian Cain
b8bf424678
Only grab provider disk config if it exists
2020-02-10 12:58:11 -08:00
Brian Cain
2600178d18
Move UI messages into methods
2020-02-10 12:58:11 -08:00
Brian Cain
a75630e274
Enable experimental flag for virtualbox disk configs
2020-02-10 12:58:11 -08:00
Brian Cain
a38f0bb8c0
Improve default vagrant disk name
2020-02-10 12:58:11 -08:00
Brian Cain
f076ee4708
Add method docs
2020-02-10 12:58:11 -08:00
Brian Cain
616f8e4bd6
Add experimental flags
2020-02-10 12:58:11 -08:00
