Mitchell Hashimoto 50d7b0aba4 Fix bug where Call didn't propagate recovery. Warden has no recovery.
The issue here is that when a middleware failed and a recovery sequence
started, it would halt at the "call" step because the "Call" didn't
properly recover the child sequence.

An additional issue was that a Warden had no "recover" method, meaning
embedded Wardens wouldn't recover their stacks properly.
2012-12-23 16:29:25 -08:00

115 lines
2.6 KiB
Ruby

require File.expand_path("../../../../base", __FILE__)
describe Vagrant::Action::Builtin::Call do
let(:app) { lambda { |env| } }
let(:env) { {} }
it "should yield the env to the block" do
received = nil
callable = lambda do |env|
env[:result] = "value"
end
described_class.new(app, env, callable) do |env, builder|
received = env[:result]
end.call({})
received.should == "value"
end
it "should call the callable with the original environment" do
received = nil
callable = lambda { |env| received = env[:foo] }
described_class.new(app, env, callable) do |_env, _builder|
# Nothing.
end.call({ :foo => :bar })
received.should == :bar
end
it "should call the next builder" do
received = nil
callable = lambda { |env| }
next_step = lambda { |env| received = "value" }
described_class.new(app, env, callable) do |_env, builder|
builder.use next_step
end.call({})
received.should == "value"
end
it "should call the next builder with the original environment" do
received = nil
callable = lambda { |env| }
next_step = lambda { |env| received = env[:foo] }
described_class.new(app, env, callable) do |_env, builder|
builder.use next_step
end.call({ :foo => :bar })
received.should == :bar
end
it "should call the recover method for the sequence in an error" do
# Basic variables
callable = lambda { |env| }
# Build the steps for the test
basic_step = Class.new do
def initialize(app, env)
@app = app
@env = env
end
def call(env)
@app.call(env)
end
end
step_a = Class.new(basic_step) do
def call(env)
env[:steps] << :call_A
super
end
def recover(env)
env[:steps] << :recover_A
end
end
step_b = Class.new(basic_step) do
def call(env)
env[:steps] << :call_B
super
end
def recover(env)
env[:steps] << :recover_B
end
end
instance = described_class.new(app, env, callable) do |_env, builder|
builder.use step_a
builder.use step_b
end
env[:steps] = []
instance.call(env)
instance.recover(env)
env[:steps].should == [:call_A, :call_B, :recover_B, :recover_A]
end
it "should recover even if it failed in the callable" do
callable = lambda { |env| raise "error" }
instance = described_class.new(app, env, callable) { |_env, _builder| }
instance.call(env) rescue nil
expect { instance.recover(env) }.
to_not raise_error
end
end