Replaces use of UI doubles within tests to use actual UI instance
to ensure calls are passing parameters correctly.
552 lines
17 KiB
Ruby
552 lines
17 KiB
Ruby
require File.expand_path("../../../../base", __FILE__)
|
|
|
|
require Vagrant.source_root.join("plugins/communicators/winssh/communicator")
|
|
require Vagrant.source_root.join("plugins/communicators/winssh/config")
|
|
|
|
describe VagrantPlugins::CommunicatorWinSSH::Communicator do
|
|
include_context "unit"
|
|
|
|
let(:export_command_template){ 'export %ENV_KEY%="%ENV_VALUE%"' }
|
|
|
|
let(:ssh) do
|
|
double("ssh",
|
|
timeout: 1,
|
|
host: nil,
|
|
port: 5986,
|
|
guest_port: 5986,
|
|
keep_alive: false
|
|
)
|
|
end
|
|
|
|
let(:shell) { "cmd" }
|
|
|
|
# SSH configuration information mock
|
|
let(:winssh) do
|
|
double("winssh",
|
|
insert_key: false,
|
|
export_command_template: export_command_template,
|
|
shell: shell,
|
|
upload_directory: "C:\\Windows\\Temp"
|
|
)
|
|
end
|
|
# Configuration mock
|
|
let(:config) { double("config", winssh: winssh, ssh: ssh) }
|
|
# Provider mock
|
|
let(:provider) { double("provider") }
|
|
let(:ui) { Vagrant::UI::Silent.new }
|
|
# SSH info mock
|
|
let(:ssh_info) { double("ssh_info") }
|
|
# Machine mock built with previously defined
|
|
let(:machine) do
|
|
double("machine",
|
|
config: config,
|
|
provider: provider,
|
|
ui: ui,
|
|
ssh_info: ssh_info
|
|
)
|
|
end
|
|
# Subject instance to test
|
|
let(:communicator){ @communicator ||= described_class.new(machine) }
|
|
# Underlying net-ssh connection mock
|
|
let(:connection) { double("connection", open_channel: nil) }
|
|
# Base net-ssh connection channel mock
|
|
let(:channel) { double("channel") }
|
|
# net-ssh connection channel mock for running commands
|
|
let(:command_channel) { double("command_channel") }
|
|
# Default exit data for commands run
|
|
let(:exit_data) { double("exit_data", read_long: 0) }
|
|
# Marker used for flagging start of output
|
|
let(:command_garbage_marker) { communicator.class.const_get(:CMD_GARBAGE_MARKER) }
|
|
# Start marker output when PTY is enabled
|
|
let(:pty_delim_start) { communicator.class.const_get(:PTY_DELIM_START) }
|
|
# End marker output when PTY is enabled
|
|
let(:pty_delim_end) { communicator.class.const_get(:PTY_DELIM_END) }
|
|
# Command output returned on stdout
|
|
let(:command_stdout_data) { '' }
|
|
# Command output returned on stderr
|
|
let(:command_stderr_data) { '' }
|
|
# Mock for net-ssh sftp
|
|
let(:sftp) { double("sftp") }
|
|
# Prevent connection patching by default in tests
|
|
let(:winssh_patch) { true }
|
|
|
|
# Setup for commands using the net-ssh connection. This can be reused where needed
|
|
# by providing to `before`
|
|
connection_setup = proc do
|
|
connection.instance_variable_set(:@winssh_patched, winssh_patch)
|
|
allow(connection).to receive(:logger)
|
|
allow(connection).to receive(:closed?).and_return(false)
|
|
allow(connection).to receive(:open_channel).
|
|
and_yield(channel).and_return(channel)
|
|
allow(channel).to receive(:wait).and_return(true)
|
|
allow(channel).to receive(:close)
|
|
allow(command_channel).to receive(:send_data)
|
|
allow(command_channel).to receive(:eof!)
|
|
allow(command_channel).to receive(:on_data).
|
|
and_yield(nil, command_stdout_data)
|
|
allow(command_channel).to receive(:on_extended_data).
|
|
and_yield(nil, nil, command_stderr_data)
|
|
allow(machine).to receive(:ssh_info).and_return(host: '10.1.2.3', port: 22)
|
|
allow(channel).to receive(:[]=).with(any_args).and_return(true)
|
|
allow(channel).to receive(:on_close)
|
|
allow(channel).to receive(:on_data)
|
|
allow(channel).to receive(:on_extended_data)
|
|
allow(channel).to receive(:on_request)
|
|
allow(channel).to receive(:on_process)
|
|
allow(channel).to receive(:exec).with(anything).
|
|
and_yield(command_channel, '').and_return(channel)
|
|
allow(command_channel).to receive(:on_request).with('exit-status').
|
|
and_yield(nil, exit_data)
|
|
# Return mocked net-ssh connection during setup
|
|
allow(communicator).to receive(:retryable).and_return(connection)
|
|
allow(sftp).to receive(:upload!)
|
|
allow(communicator).to receive(:sftp_connect).and_return(true)
|
|
allow(communicator).to receive(:execute).and_call_original
|
|
allow(communicator).to receive(:execute).
|
|
with(described_class.const_get(:READY_COMMAND), error_check: false).
|
|
and_return(0)
|
|
end
|
|
|
|
describe "#wait_for_ready" do
|
|
before(&connection_setup)
|
|
context "with no static config (default scenario)" do
|
|
context "when ssh_info requires a multiple tries before it is ready" do
|
|
before do
|
|
expect(machine).to receive(:ssh_info).
|
|
and_return(nil).ordered
|
|
expect(machine).to receive(:ssh_info).
|
|
and_return(host: '10.1.2.3', port: 22).ordered
|
|
end
|
|
|
|
it "retries ssh_info until ready" do
|
|
# retries are every 0.5 so buffer the timeout just a hair over
|
|
expect(communicator.wait_for_ready(0.6)).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#ready?" do
|
|
before(&connection_setup)
|
|
it "returns true if shell test is successful" do
|
|
expect(communicator.ready?).to be_truthy
|
|
end
|
|
|
|
context "with an invalid shell test" do
|
|
before do
|
|
allow(communicator).to receive(:execute).
|
|
with(described_class.const_get(:READY_COMMAND), error_check: false).
|
|
and_return(1)
|
|
end
|
|
|
|
it "returns raises SSHInvalidShell error" do
|
|
expect{ communicator.ready? }.to raise_error(Vagrant::Errors::SSHInvalidShell)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#execute" do
|
|
before(&connection_setup)
|
|
|
|
it "runs valid command and returns successful status code" do
|
|
expect(communicator.execute("command-to-run", error_check: false)).to eq(0)
|
|
end
|
|
|
|
it "prepends UUID output to command for garbage removal" do
|
|
expect(channel).to receive(:exec).
|
|
with(/Write-Output #{command_garbage_marker};\[Console\]::Error.WriteLine\('#{command_garbage_marker}'\).*/)
|
|
expect(communicator.execute("command-to-run")).to eq(0)
|
|
end
|
|
|
|
context "with command returning an error" do
|
|
let(:exit_data) { double("exit_data", read_long: 1) }
|
|
|
|
it "raises error when exit-code is non-zero" do
|
|
expect{ communicator.execute("command-to-run") }.to raise_error(Vagrant::Errors::VagrantError)
|
|
end
|
|
|
|
it "returns exit-code when exit-code is non-zero and error check is disabled" do
|
|
expect(communicator.execute("command-to-run", error_check: false)).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "with garbage content prepended to command output" do
|
|
let(:command_stdout_data) do
|
|
"Line of garbage\nMore garbage\n#{command_garbage_marker}Dir1\nDir2\n"
|
|
end
|
|
|
|
it "removes any garbage output prepended to command output" do
|
|
stdout = ''
|
|
expect(
|
|
communicator.execute("command-to-run") do |type, data|
|
|
if type == :stdout
|
|
stdout << data
|
|
end
|
|
end
|
|
).to eq(0)
|
|
expect(stdout).to eq("Dir1\nDir2\n")
|
|
end
|
|
end
|
|
|
|
context "with garbage content prepended to command stderr output" do
|
|
let(:command_stderr_data) do
|
|
"Line of garbage\nMore garbage\n#{command_garbage_marker}Dir1\nDir2\n"
|
|
end
|
|
|
|
it "removes any garbage output prepended to command stderr output" do
|
|
stderr = ''
|
|
expect(
|
|
communicator.execute("command-to-run") do |type, data|
|
|
if type == :stderr
|
|
stderr << data
|
|
end
|
|
end
|
|
).to eq(0)
|
|
expect(stderr).to eq("Dir1\nDir2\n")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#test" do
|
|
before(&connection_setup)
|
|
context "with exit code as zero" do
|
|
it "returns true" do
|
|
expect(communicator.test("dir")).to be_truthy
|
|
end
|
|
end
|
|
|
|
context "with exit code as non-zero" do
|
|
before do
|
|
expect(exit_data).to receive(:read_long).and_return(1)
|
|
end
|
|
|
|
it "returns false" do
|
|
expect(communicator.test("false.exe")).to be_falsey
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#upload" do
|
|
before do
|
|
allow(sftp).to receive(:upload)
|
|
expect(communicator).to receive(:sftp_connect).and_yield(sftp)
|
|
end
|
|
|
|
it "uploads a directory if local path is a directory" do
|
|
Dir.mktmpdir('vagrant-test') do |dir|
|
|
FileUtils.touch(File.join(dir, "test-file"))
|
|
expect(sftp).to receive(:mkdir).with(/destination/).exactly(2).times
|
|
expect(sftp).to receive(:upload!).with(an_instance_of(File), /test-file/)
|
|
communicator.upload(dir, 'C:\destination')
|
|
end
|
|
end
|
|
|
|
it "uploads a file if local path is a file" do
|
|
file = Tempfile.new('vagrant-test')
|
|
begin
|
|
expect(sftp).to receive(:mkdir).with(/destination/)
|
|
expect(sftp).to receive(:upload!).with(instance_of(File), 'C:/destination/file')
|
|
expect(Vagrant::Util::Platform).to receive(:unix_windows_path).with('C:\destination\file').
|
|
and_call_original
|
|
communicator.upload(file.path, 'C:\destination\file')
|
|
ensure
|
|
file.delete
|
|
end
|
|
end
|
|
|
|
it "does not raise custom error on non-permission errors" do
|
|
file = Tempfile.new('vagrant-test')
|
|
begin
|
|
expect(sftp).to receive(:mkdir).with(/destination/)
|
|
expect(sftp).to receive(:upload!).with(instance_of(File), 'C:/destination/file').
|
|
and_raise("Some other error")
|
|
expect{ communicator.upload(file.path, 'C:\destination\file') }.to raise_error(RuntimeError)
|
|
ensure
|
|
file.delete
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#download" do
|
|
before do
|
|
expect(communicator).to receive(:sftp_connect).and_yield(sftp)
|
|
end
|
|
|
|
it "calls sftp to download file" do
|
|
expect(sftp).to receive(:download!).with('/path/from', 'C:\path\to')
|
|
communicator.download('/path/from', 'C:\path\to')
|
|
end
|
|
end
|
|
|
|
describe "#connect" do
|
|
|
|
it "cannot be called directly" do
|
|
expect{ communicator.connect }.to raise_error(NoMethodError)
|
|
end
|
|
|
|
context "with default configuration" do
|
|
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: nil,
|
|
port: nil,
|
|
private_key_path: nil,
|
|
username: nil,
|
|
password: nil,
|
|
keys_only: true,
|
|
verify_host_key: false
|
|
)
|
|
end
|
|
|
|
it "has keys_only enabled" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_including(
|
|
keys_only: true
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "has verify_host_key disabled" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_including(
|
|
verify_host_key: false
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "does not include any private key paths" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_excluding(
|
|
keys: anything
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "includes `none` and `hostbased` auth methods" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_including(
|
|
auth_methods: ["none", "hostbased"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "with keys_only disabled and verify_host_key enabled" do
|
|
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: nil,
|
|
port: nil,
|
|
private_key_path: nil,
|
|
username: nil,
|
|
password: nil,
|
|
keys_only: false,
|
|
verify_host_key: true
|
|
)
|
|
end
|
|
|
|
it "has keys_only enabled" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_including(
|
|
keys_only: false
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "has verify_host_key disabled" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
nil, nil, hash_including(
|
|
verify_host_key: true
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "with host and port configured" do
|
|
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: '127.0.0.1',
|
|
port: 2222,
|
|
private_key_path: nil,
|
|
username: nil,
|
|
password: nil,
|
|
keys_only: true,
|
|
verify_host_key: false
|
|
)
|
|
end
|
|
|
|
it "specifies configured host" do
|
|
expect(Net::SSH).to receive(:start).with("127.0.0.1", anything, anything).
|
|
and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "has port defined" do
|
|
expect(Net::SSH).to receive(:start).with("127.0.0.1", anything, hash_including(port: 2222)).
|
|
and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "with private_key_path configured" do
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: '127.0.0.1',
|
|
port: 2222,
|
|
private_key_path: ['/priv/key/path'],
|
|
username: nil,
|
|
password: nil,
|
|
keys_only: true,
|
|
verify_host_key: false
|
|
)
|
|
end
|
|
|
|
it "includes private key paths" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
keys: ["/priv/key/path"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "includes `publickey` auth method" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
auth_methods: ["none", "hostbased", "publickey"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "with username and password configured" do
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: '127.0.0.1',
|
|
port: 2222,
|
|
private_key_path: nil,
|
|
username: 'vagrant',
|
|
password: 'vagrant',
|
|
keys_only: true,
|
|
verify_host_key: false
|
|
)
|
|
end
|
|
|
|
it "has username defined" do
|
|
expect(Net::SSH).to receive(:start).with(anything, 'vagrant', anything).
|
|
and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "has password defined" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
password: 'vagrant'
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "includes `password` auth method" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
auth_methods: ["none", "hostbased", "password"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "with password and private_key_path configured" do
|
|
|
|
before do
|
|
expect(machine).to receive(:ssh_info).and_return(
|
|
host: '127.0.0.1',
|
|
port: 2222,
|
|
private_key_path: ['/priv/key/path'],
|
|
username: 'vagrant',
|
|
password: 'vagrant',
|
|
keys_only: true,
|
|
verify_host_key: false
|
|
)
|
|
end
|
|
|
|
it "has password defined" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
password: 'vagrant'
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "includes private key paths" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
keys: ["/priv/key/path"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "includes `publickey` and `password` auth methods" do
|
|
expect(Net::SSH).to receive(:start).with(
|
|
anything, anything, hash_including(
|
|
auth_methods: ["none", "hostbased", "publickey", "password"]
|
|
)
|
|
).and_return(connection)
|
|
communicator.send(:connect)
|
|
end
|
|
end
|
|
|
|
context "when not patched for winssh" do
|
|
let(:winssh_patch) { false }
|
|
|
|
before(&connection_setup)
|
|
|
|
it "should patch the connection instance on first request" do
|
|
expect(connection).to receive(:define_singleton_method)
|
|
communicator.send(:connect)
|
|
end
|
|
|
|
it "should force powershell on exec" do
|
|
expect(channel).to receive(:exec).with(/powershell/).and_return(channel)
|
|
communicator.execute("test", error_check: false)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#generate_environment_export" do
|
|
let(:winssh) do
|
|
@c ||= VagrantPlugins::CommunicatorWinSSH::Config.new
|
|
@c.finalize!
|
|
@c
|
|
end
|
|
|
|
it "should generate bourne shell compatible export" do
|
|
expect(communicator.send(:generate_environment_export, "TEST", "value")).to eq("$env:TEST=\"value\"\n")
|
|
end
|
|
|
|
context "with custom template defined" do
|
|
let(:winssh) do
|
|
@c ||= VagrantPlugins::CommunicatorWinSSH::Config.new
|
|
@c.export_command_template = "setenv %ENV_KEY% %ENV_VALUE%"
|
|
@c.finalize!
|
|
@c
|
|
end
|
|
|
|
it "should generate custom export based on template" do
|
|
expect(communicator.send(:generate_environment_export, "TEST", "value")).to eq("setenv TEST value\n")
|
|
end
|
|
end
|
|
end
|
|
end
|