ff95fc5c1e
This fixes GH-6395 by only appending the access_token once. It also fixes a bug that was never reported. If a user supplied an access_token for a box URL, Vagrant would silently overwrite it. After this commit, Vagrant only appends an access_token to the URL if no value exists at the key.
105 lines
2.9 KiB
Ruby
105 lines
2.9 KiB
Ruby
require File.expand_path("../../../../../base", __FILE__)
|
|
|
|
require Vagrant.source_root.join("plugins/commands/login/middleware/add_authentication")
|
|
|
|
describe VagrantPlugins::LoginCommand::AddAuthentication do
|
|
include_context "unit"
|
|
|
|
let(:app) { lambda { |env| } }
|
|
let(:env) { {
|
|
env: iso_env,
|
|
} }
|
|
|
|
let(:iso_env) { isolated_environment.create_vagrant_env }
|
|
let(:server_url) { "http://foo.com" }
|
|
|
|
subject { described_class.new(app, env) }
|
|
|
|
before do
|
|
allow(Vagrant).to receive(:server_url).and_return(server_url)
|
|
stub_env("ATLAS_TOKEN" => nil)
|
|
end
|
|
|
|
describe "#call" do
|
|
it "does nothing if we have no server set" do
|
|
allow(Vagrant).to receive(:server_url).and_return(nil)
|
|
VagrantPlugins::LoginCommand::Client.new(iso_env).store_token("foo")
|
|
|
|
original = ["foo", "#{server_url}/bar"]
|
|
env[:box_urls] = original.dup
|
|
|
|
subject.call(env)
|
|
|
|
expect(env[:box_urls]).to eq(original)
|
|
end
|
|
|
|
it "does nothing if we aren't logged in" do
|
|
original = ["foo", "#{server_url}/bar"]
|
|
env[:box_urls] = original.dup
|
|
|
|
subject.call(env)
|
|
|
|
expect(env[:box_urls]).to eq(original)
|
|
end
|
|
|
|
it "appends the access token to the URL of server URLs" do
|
|
token = "foobarbaz"
|
|
VagrantPlugins::LoginCommand::Client.new(iso_env).store_token(token)
|
|
|
|
original = [
|
|
"http://google.com/box.box",
|
|
"#{server_url}/foo.box",
|
|
"#{server_url}/bar.box?arg=true",
|
|
]
|
|
|
|
expected = original.dup
|
|
expected[1] = "#{original[1]}?access_token=#{token}"
|
|
expected[2] = "#{original[2]}&access_token=#{token}"
|
|
|
|
env[:box_urls] = original.dup
|
|
subject.call(env)
|
|
|
|
expect(env[:box_urls]).to eq(expected)
|
|
end
|
|
|
|
it "appends the access token to vagrantcloud.com URLs if Atlas" do
|
|
server_url = "https://atlas.hashicorp.com"
|
|
allow(Vagrant).to receive(:server_url).and_return(server_url)
|
|
|
|
token = "foobarbaz"
|
|
VagrantPlugins::LoginCommand::Client.new(iso_env).store_token(token)
|
|
|
|
original = [
|
|
"http://google.com/box.box",
|
|
"http://vagrantcloud.com/foo.box",
|
|
"http://vagrantcloud.com/bar.box?arg=true",
|
|
]
|
|
|
|
expected = original.dup
|
|
expected[1] = "#{original[1]}?access_token=#{token}"
|
|
expected[2] = "#{original[2]}&access_token=#{token}"
|
|
|
|
env[:box_urls] = original.dup
|
|
subject.call(env)
|
|
|
|
expect(env[:box_urls]).to eq(expected)
|
|
end
|
|
|
|
it "does not append multiple access_tokens" do
|
|
token = "foobarbaz"
|
|
VagrantPlugins::LoginCommand::Client.new(iso_env).store_token(token)
|
|
|
|
original = [
|
|
"#{server_url}/foo.box?access_token=existing",
|
|
"#{server_url}/bar.box?arg=true",
|
|
]
|
|
|
|
env[:box_urls] = original.dup
|
|
subject.call(env)
|
|
|
|
expect(env[:box_urls][0]).to eq("#{server_url}/foo.box?access_token=existing")
|
|
expect(env[:box_urls][1]).to eq("#{server_url}/bar.box?arg=true&access_token=foobarbaz")
|
|
end
|
|
end
|
|
end
|