5a4f345363
This fixes a fairly large tempfile leak. Vagrant uses a template renderer to write network configuration files locally to disk. Then, that temporarily file is uploaded to the remote host and moved into place. Since Vagrant is such a short-lived process, GC never came along and cleaned up those tempfiles, resulting in many temporary files being created through regular Vagrant usage. The Util::Tempfile class uses a block to ensure the temporary file is deleted when the block finishes. This API required small tweaks to the usage, but provides more safety to ensure the files are deleted.
65 lines
2.7 KiB
Ruby
65 lines
2.7 KiB
Ruby
require "set"
|
|
|
|
require_relative "../../../../lib/vagrant/util/template_renderer"
|
|
require_relative "../../../../lib/vagrant/util/tempfile"
|
|
|
|
module VagrantPlugins
|
|
module GuestDebian
|
|
module Cap
|
|
class ConfigureNetworks
|
|
include Vagrant::Util
|
|
|
|
def self.configure_networks(machine, networks)
|
|
machine.communicate.tap do |comm|
|
|
# First, remove any previous network modifications
|
|
# from the interface file.
|
|
comm.sudo("sed -e '/^#VAGRANT-BEGIN/,$ d' /etc/network/interfaces > /tmp/vagrant-network-interfaces.pre")
|
|
comm.sudo("sed -ne '/^#VAGRANT-END/,$ p' /etc/network/interfaces | tac | sed -e '/^#VAGRANT-END/,$ d' | tac > /tmp/vagrant-network-interfaces.post")
|
|
|
|
# Accumulate the configurations to add to the interfaces file as
|
|
# well as what interfaces we're actually configuring since we use that
|
|
# later.
|
|
interfaces = Set.new
|
|
entries = []
|
|
networks.each do |network|
|
|
interfaces.add(network[:interface])
|
|
entry = TemplateRenderer.render("guests/debian/network_#{network[:type]}",
|
|
options: network)
|
|
|
|
entries << entry
|
|
end
|
|
|
|
# Perform the careful dance necessary to reconfigure the network
|
|
# interfaces.
|
|
Tempfile.create("debian-configure-networks") do |f|
|
|
f.write(entries.join("\n"))
|
|
f.fsync
|
|
f.close
|
|
comm.upload(f.path, "/tmp/vagrant-network-entry")
|
|
end
|
|
|
|
# Bring down all the interfaces we're reconfiguring. By bringing down
|
|
# each specifically, we avoid reconfiguring eth0 (the NAT interface) so
|
|
# SSH never dies.
|
|
interfaces.each do |interface|
|
|
# Ubuntu 16.04+ returns an error when downing an interface that
|
|
# does not exist. The `|| true` preserves the behavior that older
|
|
# Ubuntu versions exhibit and Vagrant expects (GH-7155)
|
|
comm.sudo("/sbin/ifdown eth#{interface} 2> /dev/null || true")
|
|
comm.sudo("/sbin/ip addr flush dev eth#{interface} 2> /dev/null")
|
|
end
|
|
|
|
comm.sudo('cat /tmp/vagrant-network-interfaces.pre /tmp/vagrant-network-entry /tmp/vagrant-network-interfaces.post > /etc/network/interfaces')
|
|
comm.sudo('rm -f /tmp/vagrant-network-interfaces.pre /tmp/vagrant-network-entry /tmp/vagrant-network-interfaces.post')
|
|
|
|
# Bring back up each network interface, reconfigured
|
|
interfaces.each do |interface|
|
|
comm.sudo("/sbin/ifup eth#{interface}")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|