142b1af0cc
The local-exec push strategy was assuming it was running from a CLI and so it wouldn't be a big deal for it to straight up `exec` and replace its running with the user command. That command will just do its thing and we want the exit code for the CLI command to match anyways, right? Sure that works for a shell, but in a GRPC server setting it's decidedly Not Cool to suddenly swap out the running process! As you can imagine - the effect of doing this was all sorts of broken pipes and unexpected EOFs and a very confused @phinze. Luckily we had a subprocess strategy sitting right there for Windows compat, so it was just a matter of switching to that in the server context as well. Long and winding debugging process; simple fix; just another classic!
89 lines
2.5 KiB
Ruby
89 lines
2.5 KiB
Ruby
require "fileutils"
|
|
require "tempfile"
|
|
require "vagrant/util/safe_exec"
|
|
|
|
require_relative "errors"
|
|
|
|
module VagrantPlugins
|
|
module LocalExecPush
|
|
class Push < Vagrant.plugin("2", :push)
|
|
@@logger = Log4r::Logger.new("vagrant::push::local_exec")
|
|
|
|
def push
|
|
if config.inline
|
|
execute_inline!(config.inline, config.args)
|
|
else
|
|
execute_script!(config.script, config.args)
|
|
end
|
|
end
|
|
|
|
# Execute the inline script by writing it to a tempfile and executing.
|
|
def execute_inline!(inline, args)
|
|
script = Tempfile.new(["vagrant-local-exec-script", ".sh"])
|
|
script.write(inline)
|
|
script.rewind
|
|
script.close
|
|
|
|
execute_script!(script.path, args)
|
|
ensure
|
|
if script
|
|
script.close
|
|
script.unlink
|
|
end
|
|
end
|
|
|
|
# Execute the script, expanding the path relative to the current env root.
|
|
def execute_script!(path, args)
|
|
path = File.expand_path(path, env.root_path)
|
|
FileUtils.chmod("+x", path)
|
|
|
|
if args.is_a?(String)
|
|
args = " #{args.to_s}"
|
|
elsif args.is_a?(Array)
|
|
args = args.map { |a| quote_and_escape(a) }
|
|
args = " #{args.join(" ")}"
|
|
end
|
|
|
|
execute!("#{path}#{args}")
|
|
end
|
|
|
|
# Execute the script, raising an exception if it fails.
|
|
def execute!(*cmd)
|
|
if Vagrant::Util::Platform.windows? || Vagrant.server_mode?
|
|
execute_subprocess!(*cmd)
|
|
else
|
|
execute_exec!(*cmd)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
# Quote and escape strings for shell execution, thanks to Capistrano.
|
|
def quote_and_escape(text, quote = '"')
|
|
"#{quote}#{text.gsub(/#{quote}/) { |m| "#{m}\\#{m}#{m}" }}#{quote}"
|
|
end
|
|
|
|
# Run the command as exec (unix).
|
|
def execute_exec!(*cmd)
|
|
@@logger.debug("executing command via exec: #{cmd.inspect}")
|
|
Vagrant::Util::SafeExec.exec(cmd[0], *cmd[1..-1])
|
|
end
|
|
|
|
# Run the command as a subprocess (windows).
|
|
def execute_subprocess!(*cmd)
|
|
@@logger.debug("executing command via subprocess: #{cmd.inspect}")
|
|
cmd = cmd.dup << { notify: [:stdout, :stderr] }
|
|
result = Vagrant::Util::Subprocess.execute(*cmd) do |type, data|
|
|
if type == :stdout
|
|
@env.ui.info(data, new_line: false)
|
|
elsif type == :stderr
|
|
@env.ui.warn(data, new_line: false)
|
|
end
|
|
end
|
|
|
|
Kernel.exit(result.exit_code) unless Vagrant.server_mode?
|
|
end
|
|
end
|
|
end
|
|
end
|