From 0a079914852761645e112cbfc63e3a83b5d62889 Mon Sep 17 00:00:00 2001 From: Michael Becker Date: Mon, 6 Oct 2025 00:14:59 -0400 Subject: [PATCH] GR - Get Relationship Method cannot be static, right? --- .../src/lib/Mocha.Core/OmsMethodBuilder.cs | 16 ++++++++-------- .../MethodTests/GetRelationshipTests.cs | 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/mocha-dotnet/src/lib/Mocha.Core/OmsMethodBuilder.cs b/mocha-dotnet/src/lib/Mocha.Core/OmsMethodBuilder.cs index d8109d4..6ad97c5 100644 --- a/mocha-dotnet/src/lib/Mocha.Core/OmsMethodBuilder.cs +++ b/mocha-dotnet/src/lib/Mocha.Core/OmsMethodBuilder.cs @@ -168,21 +168,21 @@ public class OmsMethodBuilder return new AssignAttributeMethod(method); } - public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, bool isStatic, Relationship returnsRelationship, bool singular = false) + public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, Relationship returnsRelationship, bool singular = false) { - return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, isStatic, Guid.NewGuid(), returnsRelationship.GetHandle(), singular); + return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, Guid.NewGuid(), returnsRelationship.GetHandle(), singular); } - public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, bool isStatic, Guid globalIdentifier, Relationship returnsRelationship, bool singular = false) + public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, Guid globalIdentifier, Relationship returnsRelationship, bool singular = false) { - return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, isStatic, globalIdentifier, returnsRelationship.GetHandle(), singular); + return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, globalIdentifier, returnsRelationship.GetHandle(), singular); } - public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, bool isStatic, InstanceHandle returnsRelationship, bool singular = false) + public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, InstanceHandle returnsRelationship, bool singular = false) { - return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, isStatic, Guid.NewGuid(), returnsRelationship, singular); + return CreateGetRelationshipMethod(forClassInstance, verb, name, accessModifier, Guid.NewGuid(), returnsRelationship, singular); } - public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, bool isStatic, Guid globalIdentifier, InstanceHandle returnsRelationship, bool singular = false) + public GetRelationshipMethod CreateGetRelationshipMethod(InstanceHandle forClassInstance, string verb, string name, AccessModifier accessModifier, Guid globalIdentifier, InstanceHandle returnsRelationship, bool singular = false) { - InstanceHandle method = CreateMethodBase(Oms.GetInstance(KnownInstanceGuids.MethodClasses.GetRelationshipMethod), forClassInstance, verb, name, accessModifier, isStatic, globalIdentifier); + InstanceHandle method = CreateMethodBase(Oms.GetInstance(KnownInstanceGuids.MethodClasses.GetRelationshipMethod), forClassInstance, verb, name, accessModifier, false, globalIdentifier); Oms.AssignRelationship(method, Oms.GetInstance(KnownRelationshipGuids.Get_Relationship_Method__returns__Relationship), returnsRelationship); Oms.SetAttributeValue(method, Oms.GetInstance(KnownAttributeGuids.Boolean.Singular), singular); return new GetRelationshipMethod(method); diff --git a/mocha-dotnet/tests/Mocha.Core.Tests/MethodTests/GetRelationshipTests.cs b/mocha-dotnet/tests/Mocha.Core.Tests/MethodTests/GetRelationshipTests.cs index 99989cd..38f2da5 100644 --- a/mocha-dotnet/tests/Mocha.Core.Tests/MethodTests/GetRelationshipTests.cs +++ b/mocha-dotnet/tests/Mocha.Core.Tests/MethodTests/GetRelationshipTests.cs @@ -35,7 +35,7 @@ public class GetRelationshipTests : MethodTestsBase Oms.AssignRelationship(i_TestClass, r_Test_Class__has__Test_Class_2, i_TestClass2); OmsMethodBuilder builder = new OmsMethodBuilder(Oms); - GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "get", "Test Class.has Test Class 2", AccessModifier.Public, true, r_Test_Class__has__Test_Class_2, true); + GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "get", "Test Class.has Test Class 2", AccessModifier.Public, r_Test_Class__has__Test_Class_2, true); ReturnInstanceSetMethodBinding rsmb = builder.CreateReturnInstanceSetMethodBinding(method); OmsContext context = Oms.CreateContext(); @@ -64,7 +64,7 @@ public class GetRelationshipTests : MethodTestsBase OmsMethodBuilder builder = new OmsMethodBuilder(Oms); - GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "take one from", "Test Class.has multiple Test Class 2", AccessModifier.Public, true, r_Test_Class__has_multiple__Test_Class_2, true); + GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "take one from", "Test Class.has multiple Test Class 2", AccessModifier.Public, r_Test_Class__has_multiple__Test_Class_2, true); ReturnInstanceSetMethodBinding rsmb = builder.CreateReturnInstanceSetMethodBinding(method); OmsContext context = Oms.CreateContext(); @@ -94,7 +94,7 @@ public class GetRelationshipTests : MethodTestsBase OmsMethodBuilder builder = new OmsMethodBuilder(Oms); - GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "get", "Test Class.has multiple Test Class 2", AccessModifier.Public, true, r_Test_Class__has_multiple__Test_Class_2, false); + GetRelationshipMethod method = builder.CreateGetRelationshipMethod(c_TestClass, "get", "Test Class.has multiple Test Class 2", AccessModifier.Public, r_Test_Class__has_multiple__Test_Class_2, false); ReturnInstanceSetMethodBinding rsmb = builder.CreateReturnInstanceSetMethodBinding(method); OmsContext context = Oms.CreateContext();