Brian Cain
8af2e5c8be
Cast to float on conversation, and return helper size vars to integer
2020-02-10 13:01:41 -08:00
Brian Cain
567351a2af
Disk doc updates
2020-02-10 12:58:11 -08:00
Brian Cain
b2a89f8711
Remove old comment on vbox driver disk method
2020-02-10 12:58:11 -08:00
Brian Cain
4394962f56
Include default disk_ext option in docs
2020-02-10 12:58:11 -08:00
Brian Cain
0aa8a517c4
Add note about resizing VMDK disks
2020-02-10 12:58:11 -08:00
Brian Cain
bb8f04f18a
Add docs note about disk_meta file
2020-02-10 12:58:11 -08:00
Brian Cain
fe6be8c886
Disk doc updates
2020-02-10 12:58:11 -08:00
Brian Cain
a15016931a
Add more docs for disk feature
2020-02-10 12:58:11 -08:00
Brian Cain
773a3aeb7e
Add optional hash arguments to driver methods
2020-02-10 12:58:11 -08:00
Brian Cain
90461014db
Website updates for disk management feature
2020-02-10 12:58:11 -08:00
Brian Cain
edd9ec89cb
Begin to add docs for the virtualbox disk feature
2020-02-10 12:58:11 -08:00
Brian Cain
f59a5c2c70
Enable virtualbox and disk config in single flag
2020-02-10 12:58:11 -08:00
Brian Cain
b594715ded
Add tests for resizing disks
2020-02-10 12:58:11 -08:00
Brian Cain
0ea26b9506
Add test for comparing disk size
2020-02-10 12:58:11 -08:00
Brian Cain
d1d27a3b56
Add tests for handle_configure_disk
2020-02-10 12:58:11 -08:00
Brian Cain
54f17929b5
Add note about vbox gui for troubleshooting
2020-02-10 12:58:11 -08:00
Brian Cain
6872625609
Add more tests for configure_disks virtualbox cap
2020-02-10 12:58:11 -08:00
Brian Cain
a9e678327b
Update docs for disk name
2020-02-10 12:58:11 -08:00
Brian Cain
337f7dd616
Add cleanup_disks tests
2020-02-10 12:58:11 -08:00
Brian Cain
b41147237e
Begin to add docs for disk configuration with virtualbox
2020-02-10 12:58:11 -08:00
Brian Cain
b9a72ce8ff
Make get_port_and_device disk method a driver method instead
2020-02-10 12:58:11 -08:00
Brian Cain
252a7f7a4e
Do not clean up and detach primary disk
2020-02-10 12:58:11 -08:00
Brian Cain
9150d3db7b
Always cleanup disks even if no disks in Vagrantfile
2020-02-10 12:58:11 -08:00
Brian Cain
eff3d47f82
Add cleanup_disks test
2020-02-10 12:58:11 -08:00
Brian Cain
9ca535dbfa
Add test for writing disk_meta file
2020-02-10 12:58:11 -08:00
Brian Cain
718332b35e
Fixup disk tests
2020-02-10 12:58:11 -08:00
Brian Cain
8cd04db602
Update configuration with disk_ext option
2020-02-10 12:58:11 -08:00
Brian Cain
8654b2bb67
Add note about provider specific disk configs
2020-02-10 12:58:11 -08:00
Brian Cain
72576d3046
Rename method for clarity for what it handles
2020-02-10 12:58:11 -08:00
Brian Cain
6ea3c3f40e
Move current_disk work into own method
2020-02-10 12:58:11 -08:00
Brian Cain
e4782e9d6a
Add method doc for method
2020-02-10 12:58:11 -08:00
Brian Cain
236815f2ff
Attempt to connect vagrant managed disks to guest if not attached
2020-02-10 12:58:11 -08:00
Brian Cain
d215d9d785
Only log warning when cleaning up disks
...
If a disk exists but isn't attached to a guest, don't attempt to remove
disk from guest.
2020-02-10 12:58:11 -08:00
Brian Cain
2e53c21fea
Return empty hash instead of null from configure_disks
2020-02-10 12:58:11 -08:00
Brian Cain
ca26afa299
Don't write disk_meta file if no disks to configure
2020-02-10 12:58:11 -08:00
Brian Cain
df742603cb
Add code comment about when SATA controller has no more open ports
2020-02-10 12:58:11 -08:00
Brian Cain
3d4d0be58f
Attach disk to next available port to avoid port fragmentation
...
This commit ensures that vagrant attaches a new disk to the _next
available_ port, rather than the last one "used". This can occur if a
disk has been removed in a previous run, leaving a port open
2020-02-10 12:58:11 -08:00
Brian Cain
c0fb8af1a3
Fix NUMBER typo
2020-02-10 12:58:11 -08:00
Brian Cain
2db81b049b
Only look at SATA Controller disk images
2020-02-10 12:58:11 -08:00
Brian Cain
f6a5a3ae41
Simplify determining next port to use
2020-02-10 12:58:11 -08:00
Brian Cain
9a5ce8381b
Add comment field for new disks
2020-02-10 12:58:11 -08:00
Brian Cain
98a81aac6b
Move show_vm_info call
2020-02-10 12:58:11 -08:00
Brian Cain
1b5f8760d0
Simplify get_port_device and add note about duplicated method in class
2020-02-10 12:58:11 -08:00
Brian Cain
8407fb28cb
Add more code comments for configuring disk class
2020-02-10 12:58:11 -08:00
Brian Cain
6376962209
Simplify obtaining port and device number info
2020-02-10 12:58:11 -08:00
Brian Cain
c049dd9211
Rename method to match functionality
...
This method now only returns the next available port, as virtualbox
guests can only have 1 device controller.
2020-02-10 12:58:11 -08:00
Brian Cain
6676fe6f7f
Remove stale TODOs
2020-02-10 12:58:11 -08:00
Brian Cain
524d98fe5c
Add comment about MAX_DISK_SIZE const
2020-02-10 12:58:11 -08:00
Brian Cain
cb3cc42dce
Determine primary disk through vm_info rather than list_hdds
2020-02-10 12:58:11 -08:00
Brian Cain
17b75db35b
Move disk driver methods into virtualbox version 5
2020-02-10 12:58:11 -08:00
