8365 Commits

Author SHA1 Message Date
Gilles Cornu
ddbd2a4cfc provisioners/ansible: prefer ssh '-i' argument
In cd93721, I relied on a suprising combination of quotes to protect ssh
execution to strip the quoted path to the private key file.
Since any ssh command line argument can be passed via
`ANSIBLE_SSH_ARGS`, it is quite more readable and easy to rely on the
`-i` argument, which is not affected like `-o IdentityFile=...` and also
supports multiple occurences.

See also http://sourceforge.net/p/fuse/mailman/message/30498048/

Finally fix #6671

Note that I decided to not squash both commits for better
documentation and traceability.
2015-12-16 10:29:13 +01:00
Gilles Cornu
cd93721f8f provisioners/ansible: use quotes for the IdentityFile OpenSSH command line arguments
Surprisingly (to me at least), a simple quote enclosure was not enough
to fix the problem.

Caveat: the stringified ansible-playbook command logged in verbose mode
is wrongly formatted (no quotes are escaped).

Fix #6671
2015-12-16 09:54:53 +01:00
Mitchell Hashimoto
ac3b24d93e Update CHANGELOG.md 2015-12-14 16:03:07 -08:00
Mitchell Hashimoto
06a1461081 Merge pull request #6662 from lukebakken/fixes/lrb/gh-4503-hyper-v-admin-privs
Fix for 4503
2015-12-14 15:56:55 -08:00
Mitchell Hashimoto
6a9d25e384 Update CHANGELOG.md 2015-12-14 15:47:58 -08:00
Mitchell Hashimoto
884782f3ce Merge pull request #6603 from mitchellh/sethvargo/cleanup_output
Only run cleanup tasks when they are defined on the provisioner
2015-12-14 15:41:17 -08:00
Mitchell Hashimoto
739d29e8fa Merge pull request #6612 from reedloden/virtualbox-checksum
Add checksum validation for the VirtualBox installs on Windows and OS X
2015-12-14 15:39:46 -08:00
Mitchell Hashimoto
d47c7c74d7 Merge pull request #6659 from swiftstack/change_ipv6_adapter_address
Use <prefix>::1 as the IPv6 adapter IP.
2015-12-14 15:37:28 -08:00
Seth Vargo
038276fd49 Merge pull request #6664 from RochesterinNYC/clarify-package-docs-regarding-providers
Clarify package documentation regarding providers
2015-12-10 13:24:08 -05:00
James Wen
c5f684c6da Clarify package documentation regarding providers 2015-12-10 12:48:13 -05:00
Seth Vargo
fa2db94b7d Update CHANGELOG 2015-12-10 11:26:57 -05:00
Seth Vargo
e92a214803 Merge pull request #6661 from hasyimibhar/feature/push-local-exec-args
pushes/local-exec: add args config
2015-12-10 11:26:09 -05:00
Luke Bakken
57187c9f88 Add method to detect if a Windows user is a member of the "Hyper-V Administrators" group.
Modify Hyper-V provider to require a user to either be an Administrator or a member of "Hyper-V Administrators"
2015-12-10 07:04:39 -08:00
Hasyimi Bahrudin
77031a79b7 pushes/local-exec: add args config 2015-12-10 17:00:35 +08:00
Timur Alperovich
a56e118b16 Use <prefix>::1 as the IPv6 adapter IP.
Set the IPv6 adapter IP to be <prefix>::1. Otherwise, guest to host
communication over IPv6 is not routed correctly. This means that
consumers should not specify <prefix>::1 IP addresses to VirtualBox,
which should be a reasonable restriction.

Fixes #6658
2015-12-09 17:22:02 -08:00
Gilles Cornu
25ff027b08 provisioners/ansible_local: use the inventory directory
Like in the (remote) `ansible` provisioner, it is preferred to pass the
directory that contains the generated inventory file. This way, advanced
inventory usages can be achieved by adding more inventory files into the
same directory.

Related to #2103 and #6500

[ci skip]
2015-12-08 23:02:58 +01:00
Gilles Cornu
e5c5dfbacd Update CHANGELOG
- Fix reference to relevant pull request #6288
- See also #6649

[ci skip]
2015-12-08 22:11:30 +01:00
Seth Vargo
af509e0a2b Update CHANGELOG 2015-12-08 11:17:11 -05:00
Seth Vargo
3ac1bfc6d9 Merge pull request #6652 from mitchellh/pr-6596
Only consider the VM interfaces in the IPv6 fixup
2015-12-08 11:15:22 -05:00
Seth Vargo
aca1e041f6 Rename network to interface 2015-12-08 11:05:39 -05:00
Seth Vargo
9ba8cfcd50 Separate logic into other functions for readability 2015-12-08 10:52:54 -05:00
Timur Alperovich
bcf61d001b Only consider the VM interfaces in the IPv6 fixup.
Vagrant should only consider the host-only interfaces used by the
virtual machine in the IPv6 fixup code. There may be other interfaces
present on the system with IPv6 addresses that for various reasons
would fail the routing check (for example, an interface with no
machines attached).

The patch changes the behavior to not scan all of the host-only
interfaces and adds a unit test for the behavior (that the correct IP
is validated).

Lastly, there is a small fix here that may not be an issue for most
people where the IPv6 prefix was asummed to be a multiple of 16 for
the purposes of constructing the UDP probe datagram. This assumption
has been removed.

Fixes #6586
2015-12-08 10:44:07 -05:00
Gilles Cornu
a8d0c225c6 Merge pull request #6649 from rickard-von-essen:issue-6636
Close #6636

Note that there is no CHANGELOG entry for this bug fix, since the
`ansible_local` provisioner [#2103] has not been released yet.
2015-12-07 22:41:06 +01:00
Gilles Cornu
a0980aa8be provisioners/ansible: minor code formatting change
[ci skip]
2015-12-07 22:30:13 +01:00
Gilles Cornu
850716b220 provisioners/ansible: remove erroneous comment
[ci skip]
2015-12-07 22:28:23 +01:00
Seth Vargo
c60a71861f Update CHANGELOG 2015-12-07 10:58:46 -05:00
Seth Vargo
36b87bb32b Merge pull request #6650 from mitchellh/sethvargo/checksum_case
Ignore case when comparing checksums
2015-12-07 10:57:29 -05:00
Seth Vargo
5c09e94f1a Clarify that support might be in a later Vagrant version 2015-12-07 10:57:26 -05:00
Seth Vargo
4e21dd78e4 Ignore case when comparing checksums
Fixes GH-6648
2015-12-07 10:30:46 -05:00
Rickard von Essen
9f3ebef810 Support ansible install on RedHat derivates and Fedora.
Fixes #6636
2015-12-07 15:44:20 +01:00
Seth Vargo
44eac3c819 Merge pull request #6643 from mkuzmin/util-powershell
Fix `uninitialized constant` error in `vagrant powershell` command
2015-12-05 12:24:33 -05:00
Michael Kuzmin
546649fb9e Fix uninitialized constant error in vagrant powershell command 2015-12-05 17:24:58 +03:00
Gilles Cornu
c20e1bb594 provisioners/ansible: support host pattern ranges
Introduction of "unsafe" numeric or alphabetic patterns in the generated inventory

Close #3539
2015-12-05 07:11:27 +01:00
Gilles Cornu
3a793a2721 provisioners/ansible(both): minor tweak in en.yml
Related to #3539.
2015-12-05 07:10:11 +01:00
Gilles Cornu
c901e81e37 docs (ansible): update and fixes for [GH-3539]
- clearly mention that this feature is available since Vagrant 1.8.0
- reorganize the special notes
- update the examples to be more focused, and mention that a host range
  is not coherent with `Vagrantfile` machine definitions.
2015-12-05 06:59:29 +01:00
Kamjar Gerami
b7e9437a77
#3539 - Fixed syntax, language and logic according to comments made by reviewer in PR #6639 2015-12-04 10:05:07 +01:00
Kamjar Gerami
f5f568b66b
Added plain Symbol group name for unit test 2015-12-04 02:16:01 +01:00
Kamjar Gerami
5cbbbb5e28 #3539 - Can't use alphanumeric patterns for box names in ansible.groups: Changed iteration logic for warning message and fixed regex typo 2015-12-04 01:29:22 +01:00
Kamjar Gerami
af6a80472e #3539 - Can't use alphanumeric patterns for box names in ansible.groups: added unit test for host range patterns 2015-12-04 01:26:04 +01:00
Kamjar Gerami
934bcf9419 #3539 - Can't use alphanumeric patterns for box names in ansible.groups: Host Range Pattern Regex, notification and updates to provisioning web source 2015-12-04 01:13:59 +01:00
Gilles Cornu
dde7f4697f Merge branch 'gildegoma/review-6626'
Related to #6619, #6626 and #6627
2015-12-03 21:52:34 +01:00
Gilles Cornu
cc2d11b497 provisioners/ansible+ansible_local: inventory vars
Add support for group and host variables in the generated inventory.

Close #6619
2015-12-03 21:50:53 +01:00
Gilles Cornu
8517014a99 provisioners/ansible: update inventory groups tests
With the introduction of inventory variables, group members provided as
String are not splitted (by ' ') into an array (instead of
auto-conversion to a single-item array).
2015-12-03 09:39:12 +01:00
Gilles Cornu
4c137a9b6b provisioners/ansible: fix comment indentation
[ci skip]
2015-12-03 09:36:57 +01:00
Gilles Cornu
9867281971 provisioners/ansible: allow symbol in groups key
After c49a146467f7d7a0e441564a2418a1b8a42bb8a6, it makes even more sense
to support Symbol datatypes in `groups` option handling.
2015-12-03 09:34:53 +01:00
Gilles Cornu
06e772a241 docs (ansible): update inventory host vars example
Better reflect the true generated inventory output.

[ci skip]
2015-12-03 08:14:47 +01:00
Mitchell Hashimoto
7caaffbf38 website/docs: update machine readable output options 2015-12-02 18:07:00 -08:00
Mitchell Hashimoto
30d9e243bb fix failing tests 2015-12-02 18:03:08 -08:00
Mitchell Hashimoto
350da6e1d5 commands/ssh_config: output machine readable output 2015-12-02 17:53:08 -08:00
Mitchell Hashimoto
5c4e71e317 core: machine output provider info for the machine 2015-12-02 13:06:07 -08:00