13244 Commits

Author SHA1 Message Date
Jeff Bonhag
ff53c64fbc
Fix test, add test .recover_from_resize 2020-07-09 15:09:09 -04:00
Jeff Bonhag
dfd3bc915c
Remove disks based on metadata
This commit changes the disk_cleanup behavior to remove disks based on
what has been recorded in the disk_meta file.
2020-07-09 15:09:07 -04:00
Jeff Bonhag
e01b51fa43
Disk management with a single controller
.configure_disks is responsible for determining the disk controller(s)
to use, given the machine configuration and the current disk config.
When a machine has a single controller, use it for all attachments.

When a machine has multiple controllers, attach disks to the SATA
controller and DVDs to the IDE controller.

This commit also returns additional attachment information
(controller/port/device) with the disk metadata.
2020-07-09 15:07:49 -04:00
Jeff Bonhag
c9bdcb6839
Error on unsupported storage controller type 2020-07-09 15:07:49 -04:00
Jeff Bonhag
c9be89718d
Write documentation for :dvd disk type 2020-07-09 15:07:49 -04:00
Jeff Bonhag
53f7412821
Make VirtualBoxDisksDefinedExceedLimit error generic
Create a #limit method in the StorageController class so we can
customize the error message when a storage controller is full.
2020-07-09 15:07:49 -04:00
Jeff Bonhag
1e6eb0d636
Raise an error if primary disk can't be found 2020-07-09 15:07:49 -04:00
Jeff Bonhag
8561467e40
IDE controllers have two devices/port 2020-07-09 15:07:49 -04:00
Jeff Bonhag
b9705214bd
Replace backticks with single quotes 2020-07-09 15:07:48 -04:00
Jeff Bonhag
61f43fb59f
Require controller name for #remove_disk
Also use #get_controller methods when attaching a disk.
2020-07-09 15:07:48 -04:00
Jeff Bonhag
4736fbc88f
Require storage controller for .get_next_port
This also includes #get_controller refactorings and cleanup for the
cleanup_disks capabaility.
2020-07-09 15:07:48 -04:00
Jeff Bonhag
958023dbb9
Create #get_controller method in driver
This makes it easier to check if the required controller can be found,
and automatically raise an error if it is not.

Add a #storage_bus method to the StorageController class as a shorthand
way to check the general storage controller type.
2020-07-09 15:07:48 -04:00
Jeff Bonhag
3a515cc7d6
Error if the required storage controller not found
This commit adds a new error type that can be raised whenever a storage
controller of the required type is not found. This indicates that a user
needs to either add the storage controller manually or change their disk
configuration.

It also removes the last hardcoded instance of "SATA Controller" as a
default argument.
2020-07-09 15:07:48 -04:00
Jeff Bonhag
e21fb59380
DVD attachments should never be primary 2020-07-09 15:07:48 -04:00
Jeff Bonhag
4480eb0d88
Freeze values 2020-07-09 15:07:47 -04:00
Jeff Bonhag
38e986300b
Fix up tests to use new interface 2020-07-09 15:07:47 -04:00
Jeff Bonhag
5abde797e4
Forward #storage_controller to driver 2020-07-09 15:07:47 -04:00
Jeff Bonhag
61f59de69b
Extract StorageController object 2020-07-09 15:07:47 -04:00
Jeff Bonhag
2e879aa06f
Scan storage controllers for DVD cleanup 2020-07-09 15:07:47 -04:00
Jeff Bonhag
8739c04aa9
Mock out storage controllers 2020-07-09 15:07:47 -04:00
Jeff Bonhag
8407d79100
Refactor disk configuration to use dynamic names
This commit adds a new VirtualBox provider helper method to return a
list of storage controllers so Vagrant can find a storage controller
with the desired characteristics (type IDE or SATA).

This still needs to get wired up to the disk cleanup method.
2020-07-09 15:07:46 -04:00
Jeff Bonhag
8985369eab
Raise an error if disk files are re-used in config 2020-07-09 15:07:46 -04:00
Jeff Bonhag
c52eb1b44c
Feature: ISO attachment for VirtualBox
This builds on the existing disk functionality, and adds some special
IDE controller-related flavor.

Considerations for IDE controllers:
- Primary/secondary attachments, so that each port can have two devices
  attached
- Adding the ability to address a specific controller name for disk
  attachment

This also prevents a user from attaching multiple instances of the same
ISO file, because VirtualBox will assign each of these the same UUID
which makes disconnection difficult. However, if multiple copies of the
ISO are attached to different devices, removing the DVD config will
cause the duplicate devices to be removed.

We may want to consider additional work to make the storage controllers
truly generic.
2020-07-09 15:07:27 -04:00
Brian Cain
34747cafd6
Merge pull request #11754 from briancain/fixup/set-proper-root-dir-for-sync
Set proper root dir path for sync script
2020-07-08 14:33:23 -07:00
Brian Cain
b5b3acd1b1
Set proper root dir path for sync script 2020-07-08 14:28:40 -07:00
Brian Cain
daa2786978
Merge pull request #11405 from briancain/ci/add-gh-actions
Add config files for acceptance tests with Vagrant and GitHub Actions
2020-07-08 14:22:10 -07:00
sophia
a32f99fc1e Update CHANGELOG 2020-07-07 10:41:08 -05:00
Sophia Castellarin
02ef62dcff
Merge pull request #11694 from soapy1/host-cap-build-iso
Build iso for Darwin host
2020-07-07 10:29:52 -05:00
Jeff Bonhag
3d992bb5df
Merge pull request #11744 from ArjunDandagi/patch-1
doc-fix dont escape  $
2020-07-07 11:03:13 -04:00
Brian Cain
deb8c3d1f6
Update CHANGELOG 2020-07-06 15:25:36 -07:00
Brian Cain
88c2bc2be1
Merge pull request #11541 from briancain/feature/hyperv-disk-mgmt
[Feature] Hyper-V Virtual Hard Disk Management
2020-07-06 15:24:29 -07:00
sophia
c1283c3c66 Update CHANGELOG 2020-07-06 11:39:34 -05:00
Sophia Castellarin
9da33520e8
Merge pull request #11746 from soapy1/ambiguous-option
Print help message if user provides and ambiguous option
2020-07-06 11:38:28 -05:00
sophia
1661d1f1cf Print help message if user provides and ambiguous option 2020-07-06 10:52:05 -05:00
Arjun Dandagi
fc44b2af58
Update api.mdx
doc fix  - dont esscape $ for VAGRANT_CLOUD_TOKEN env VAR
2020-07-05 23:46:01 +05:30
Arjun Dandagi
5e5efecf39
Update api.mdx
"\" makes the $ to be escaped and causes ==>  {"errors":[{"message":"Bad credentials"}]} 
hence the doc fix :)
2020-07-05 23:14:37 +05:30
sophia
7df0e62ade Update CHANGELOG 2020-07-02 10:21:15 -05:00
Sophia Castellarin
71620f6803
Merge pull request #11631 from soapy1/error-nfs-on-win
Error nfs on win
2020-07-02 10:19:06 -05:00
sophia
afae8c5640 Make tests check for output directory creation 2020-07-02 09:53:40 -05:00
Brian Cain
d99dacf44f
Merge pull request #11706 from briancain/feature/cloud-init_setup_action
Initial commit of cloud_init setup action
2020-07-01 15:10:50 -07:00
Brian Cain
89678950ae
Update hyper-v website docs for new website format 2020-06-30 14:23:34 -07:00
Brian Cain
0139d8f020
Simplify other select to detect instead 2020-06-30 14:23:34 -07:00
Brian Cain
39b5bb4beb
Simplify selecting disk from all_disks hash 2020-06-30 14:23:34 -07:00
Brian Cain
05d3045f3a
Add RDoc for list_hdds 2020-06-30 14:23:34 -07:00
Brian Cain
9c1338b335
Fix typo in logger message 2020-06-30 14:23:34 -07:00
Brian Cain
497cb67b50
Include new disk ext cap methods in test mock ups 2020-06-30 14:23:34 -07:00
Brian Cain
af20d4a426
Remove old comment 2020-06-30 14:23:34 -07:00
Brian Cain
d35feb62a3
Simplify key check for provider option config 2020-06-30 14:23:34 -07:00
Brian Cain
b36db04b3d
Validate and get default disk extensions for provider
This commit updates the hyperv and virtualbox provider caps to validate
and also return the default disk extension.
2020-06-30 14:23:34 -07:00
Brian Cain
13c91d68a6
Only grab provider_config if provider key exists and config isn't empty 2020-06-30 14:23:34 -07:00